Juan Hernandez has posted comments on this change. Change subject: engine: boot-protocol for VmInitNetwork ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/33199/2/backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmMapper.java File backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmMapper.java: Line 1059: GuestNicConfiguration model = template != null ? template : new GuestNicConfiguration(); Line 1060: Line 1061: model.setName(entity.getName()); Line 1062: model.setOnBoot(entity.getStartOnBoot()); Line 1063: model.setBootProtocol(entity.getBootProtocol() == NetworkBootProtocol.STATIC_IP ? BootProtocol.STATIC.name() : entity.getBootProtocol().name()); I think this should be as follows: if (entity.getBootProtocol() != null) { model.setBootProtocol(BootProtocolMapper.map(entity.getBootProtocol(), null).value()); } Line 1064: IP ip = new IP(); Line 1065: model.setIp(ip); Line 1066: ip.setAddress(entity.getIp()); Line 1067: ip.setNetmask(entity.getNetmask()); -- To view, visit http://gerrit.ovirt.org/33199 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I21f8a9cf509dd4d3d6e73a83ce9f66b183605161 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shav...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Shahar Havivi <shav...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
