Alon Bar-Lev has posted comments on this change. Change subject: packaging: Adapt to splitted modules directories ......................................................................
Patch Set 3: (2 comments) http://gerrit.ovirt.org/#/c/32846/3/packaging/bin/engine-prolog.sh.in File packaging/bin/engine-prolog.sh.in: Line 28: export JAVA_HOME Line 29: Line 30: # we use jboss specific loader (jboss-modules.jar) Line 31: # setup module path Line 32: export JAVA_MODULEPATH="${TOOLS_JAVA_MODULEPATH}:${ENGINE_JAVA_MODULEPATH}:${JBOSS_HOME}/modules" > Well, modules in tools override existing modules, it doesn't matter if over well... maybe we should remove the common from the engine config as well and add both common and tools here, and add common to the engine service python script? the outcome will be similar to about... we specify the jboss here as the user may override the jboss location, so we can specify all: export JAVA_MODULEPATH="${TOOLS_JAVA_MODULEPATH}:${ENGINE_USR}/modules/tools:${ENGINE_USR}/modules/common:${ENGINE_JAVA_MODULEPATH}:${JBOSS_HOME}/mod ules" Line 33: Line 34: # clean the class path Line 35: # jboss module loader will not run otherwise. Line 36: export CLASSPATH="" http://gerrit.ovirt.org/#/c/32846/3/packaging/services/ovirt-engine/ovirt-engine.conf.in File packaging/services/ovirt-engine/ovirt-engine.conf.in: Line 128: # Line 129: # Module path which is used inside JBoss instance Line 130: ENGINE_JAVA_MODULEPATH="${ENGINE_USR}/modules/common" Line 131: # Module path which is used for tools Line 132: TOOLS_JAVA_MODULEPATH="${ENGINE_USR}/modules/tools" > TOOLS_JAVA_MODULEPATH defined here is used in engine-prolog.sh. Or am I mis this file is actually for the service... the fact that we read it from tools is incorrect, but for now... if you need to append the tools you can do this in the prolog, so that user will maintain single path for modules here. Line 133: Line 134: # Line 135: # Additional applications to be deployed in the instance of the Line 136: # application server started by the engine. This is a list of space -- To view, visit http://gerrit.ovirt.org/32846 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1b5c6efcf013350380a88db4b5b5f5973ba41eeb Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
