Martin Peřina has posted comments on this change. Change subject: packaging: Adapt to splitted modules directories ......................................................................
Patch Set 3: (3 comments) http://gerrit.ovirt.org/#/c/32846/3/packaging/bin/engine-prolog.sh.in File packaging/bin/engine-prolog.sh.in: Line 28: export JAVA_HOME Line 29: Line 30: # we use jboss specific loader (jboss-modules.jar) Line 31: # setup module path Line 32: export JAVA_MODULEPATH="${TOOLS_JAVA_MODULEPATH}:${ENGINE_JAVA_MODULEPATH}:${JBOSS_HOME}/modules" > here you should have: Well, modules in tools override existing modules, it doesn't matter if overriden modules are in common or provided by JBoss. So for me it makes sense tools modules are the 1st in path. Line 33: Line 34: # clean the class path Line 35: # jboss module loader will not run otherwise. Line 36: export CLASSPATH="" http://gerrit.ovirt.org/#/c/32846/3/packaging/services/ovirt-engine-notifier/ovirt-engine-notifier.conf.in File packaging/services/ovirt-engine-notifier/ovirt-engine-notifier.conf.in: Line 31: # Line 32: # Module path which is used inside JBoss instance Line 33: ENGINE_JAVA_MODULEPATH="${ENGINE_USR}/modules/common" Line 34: # Module path which is used for tools Line 35: TOOLS_JAVA_MODULEPATH="${ENGINE_USR}/modules/tools" > there is no reason to add tools here. I wanted the definition to be the same in all config files. But I can update to the above Line 36: Line 37: # Line 38: # Use this if you want to enable remote debugging of the notifier java virtual Line 39: # machine (useful mainly for developers): http://gerrit.ovirt.org/#/c/32846/3/packaging/services/ovirt-engine/ovirt-engine.conf.in File packaging/services/ovirt-engine/ovirt-engine.conf.in: Line 128: # Line 129: # Module path which is used inside JBoss instance Line 130: ENGINE_JAVA_MODULEPATH="${ENGINE_USR}/modules/common" Line 131: # Module path which is used for tools Line 132: TOOLS_JAVA_MODULEPATH="${ENGINE_USR}/modules/tools" > no need to add tools here, it is not used by the ovirt-engine service. TOOLS_JAVA_MODULEPATH defined here is used in engine-prolog.sh. Or am I missing something? Line 133: Line 134: # Line 135: # Additional applications to be deployed in the instance of the Line 136: # application server started by the engine. This is a list of space -- To view, visit http://gerrit.ovirt.org/32846 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1b5c6efcf013350380a88db4b5b5f5973ba41eeb Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
