Yair Zaslavsky has posted comments on this change. Change subject: uutils: Extract connectionBuilder class ......................................................................
Patch Set 7: (2 comments) http://gerrit.ovirt.org/#/c/33479/7/backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/http/ConnectionBuilder.java File backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/http/ConnectionBuilder.java: > +1, specifically since it enforces only HTTP/HTTPS protocols Done Line 1: package org.ovirt.engine.core.uutils.http; Line 2: Line 3: import java.io.File; Line 4: import java.io.FileInputStream; Line 43: Line 44: public ConnectionBuilder setURL(String url) { Line 45: try { Line 46: this.url = new URL(url); Line 47: if (!this.url.getProtocol().equalsIgnoreCase("http") && !this.url.getProtocol().equalsIgnoreCase("https")) { > there is no need to pull it, since it is already in this project is already Well, we would like to achieve minimalisim in dependencies in uutils. Hopefully people would be able to enjoy it without engine code , if needed :) i will fix the rest. Line 48: throw new RuntimeException("The URL " + url + " does not denote to an HTTP or HTTPS URL"); Line 49: } Line 50: } catch (MalformedURLException e) { Line 51: throw new IllegalArgumentException(url + " is not a valid URL"); -- To view, visit http://gerrit.ovirt.org/33479 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I85ea4e7301b3a018b0438fff25cefad80ebd7256 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
