Alon Bar-Lev has posted comments on this change. Change subject: uutils: Extract connectionBuilder class ......................................................................
Patch Set 7: (2 comments) ok, we reached simplicity now... few minors. http://gerrit.ovirt.org/#/c/33479/7/backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/http/ConnectionBuilder.java File backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/http/ConnectionBuilder.java: I still would have called this HttpURLConnectionBuilder... or Factory... to make it easier to understand what it does, not critical. Line 1: package org.ovirt.engine.core.uutils.http; Line 2: Line 3: import java.io.File; Line 4: import java.io.FileInputStream; http://gerrit.ovirt.org/#/c/33479/7/backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/servlet/ProxyServletBase.java File backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/servlet/ProxyServletBase.java: Line 87: .setTrustManagerAlgorithm(trustManagerAlgorithm) Line 88: .setTrustStore(trustStore) Line 89: .setTrustStorePassword(trustStorePassword) Line 90: .setTrustStoreType(trustStoreType) Line 91: .setURL(url.toString()) no need for toString() now. I think you should rebase and handle the set null, so that it will be valid (now, you raise exception as it is not http/https. Line 92: .setVerifyChain(verifyChain) Line 93: .setVerifyHost(verifyHost).create(); Line 94: } Line 95: -- To view, visit http://gerrit.ovirt.org/33479 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I85ea4e7301b3a018b0438fff25cefad80ebd7256 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
