Alon Bar-Lev has posted comments on this change.

Change subject: core : JBoss Servlet Exception at Page Loads :: no protocol: 
/ovirt/reports-interface
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.ovirt.org/#/c/33202/3/backend/manager/modules/services/src/main/java/org/ovirt/engine/core/services/ProxyServlet.java
File 
backend/manager/modules/services/src/main/java/org/ovirt/engine/core/services/ProxyServlet.java:

Line 56:         if (!url.startsWith(HTTP) && !url.startsWith(HTTPS)) {
Line 57:             url = null;
Line 58:         }
Line 59:         return url;
Line 60:     }
why not just check if not empty?
Line 61: 
Line 62:     @Override
Line 63:     public void init() throws ServletException {
Line 64:         setVerifyHost(getConfigBoolean(VERIFY_HOST_PRM));


-- 
To view, visit http://gerrit.ovirt.org/33202
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I485dff572fe8ce1ffb61d77b5032b540735f93f2
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rn...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com>
Gerrit-Reviewer: Ravi Nori <rn...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to