Alon Bar-Lev has posted comments on this change.

Change subject: core : JBoss Servlet Exception at Page Loads :: no protocol: 
/ovirt/reports-interface
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.ovirt.org/#/c/33202/2/backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/servlet/ProxyServletBase.java
File 
backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/servlet/ProxyServletBase.java:

Line 185:     @Override
Line 186:     protected void doGet(HttpServletRequest request, 
HttpServletResponse response)
Line 187:     throws ServletException, IOException {
Line 188: 
Line 189:         if (url == null || (!url.startsWith(HTTP) && 
!url.startsWith(HTTPS))) {
the user of this class should not set url if empty, leaving it null and proper 
functioning...
Line 190:             response.sendError(response.SC_NOT_FOUND, "Cannot proxy, 
no URL is configured.");
Line 191:         } else {
Line 192:             URLConnection connection;
Line 193:             try {


-- 
To view, visit http://gerrit.ovirt.org/33202
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I485dff572fe8ce1ffb61d77b5032b540735f93f2
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rn...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com>
Gerrit-Reviewer: Ravi Nori <rn...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to