Omer Frenkel has posted comments on this change. Change subject: core: Cluster parameters override - fields\db ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/32546/1/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmBase.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmBase.java: Line 1086: return customEmulatedMachine; Line 1087: } Line 1088: Line 1089: public void setCustomEmulatedMachine(String customEmulatedMachine) { Line 1090: this.customEmulatedMachine = ((customEmulatedMachine == null || customEmulatedMachine.length()==0) ? null : customEmulatedMachine); > Null emulated machine indicates 'fallback to cluster'. if the string is emp then use customEmulatedMachine.trim().isEmpty() Line 1091: } Line 1092: Line 1093: public String getCustomCpuName() { Line 1094: return customCpuName; -- To view, visit http://gerrit.ovirt.org/32546 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I64d829aa6a68b1c97fb59d2a7a21351a00c92c40 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eldan Shachar <eshac...@redhat.com> Gerrit-Reviewer: Eldan Shachar <eshac...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches