Eldan Shachar has posted comments on this change. Change subject: core: Cluster parameters override - fields\db ......................................................................
Patch Set 1: (2 comments) http://gerrit.ovirt.org/#/c/32546/1/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmBase.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmBase.java: Line 1086: return customEmulatedMachine; Line 1087: } Line 1088: Line 1089: public void setCustomEmulatedMachine(String customEmulatedMachine) { Line 1090: this.customEmulatedMachine = ((customEmulatedMachine == null || customEmulatedMachine.length()==0) ? null : customEmulatedMachine); > why do you need this null/empty check? Null emulated machine indicates 'fallback to cluster'. if the string is empty from some reason(e.g. UI) it probably means we should ignore the field and fallback. The null check is there just to protect the length check function call. Line 1091: } Line 1092: Line 1093: public String getCustomCpuName() { Line 1094: return customCpuName; http://gerrit.ovirt.org/#/c/32546/1/packaging/dbscripts/create_views.sql File packaging/dbscripts/create_views.sql: Line 706: vms.vds_group_cpu_name, tags_vm_map_view.tag_name, tags_vm_map_view.tag_id, vms.default_display_type, vms.priority, Line 707: vms.vds_group_compatibility_version, vms.initrd_url, vms.kernel_url, vms.kernel_params, vms.pause_status, Line 708: vms.exit_status, vms.exit_message, vms.min_allocated_mem, storage_domain_static.id AS storage_id, Line 709: vms.quota_id as quota_id, vms.quota_name as quota_name, vms.tunnel_migration as tunnel_migration, Line 710: vms.vnc_keyboard_layout as vnc_keyboard_layout, vms.is_run_and_pause as is_run_and_pause, vms.created_by_user_id as created_by_user_id, vms.vm_fqdn, vms.cpu_name as cpu_name, vms.emulated_machine as emulated_machine, > what about new fields? Done Line 711: vms.vm_pool_spice_proxy as vm_pool_spice_proxy, vms.vds_group_spice_proxy as vds_group_spice_proxy, Line 712: vms.instance_type_id as instance_type_id, vms.image_type_id as image_type_id, vms.architecture as architecture, vms.original_template_id as original_template_id, vms.original_template_name as original_template_name, Line 713: vms.migration_downtime as migration_downtime, vms.template_version_number as template_version_number, Line 714: vms.current_cd as current_cd, vms.reason as reason, -- To view, visit http://gerrit.ovirt.org/32546 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I64d829aa6a68b1c97fb59d2a7a21351a00c92c40 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eldan Shachar <eshac...@redhat.com> Gerrit-Reviewer: Eldan Shachar <eshac...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
