Lior Vernia has posted comments on this change. Change subject: engine: Extract code common for cluster network attach/update ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/32905/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/NetworkClusterCommandBase.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/NetworkClusterCommandBase.java: Line 30: NetworkClusterValidator validator = new NetworkClusterValidator(getNetworkCluster(), getClusterVersion()); Line 31: return (!NetworkUtils.isManagementNetwork(getNetwork()) Line 32: || validate(validator.managementNetworkAttachment(getNetworkName()))) Line 33: && validate(validator.migrationPropertySupported(getNetworkName())) Line 34: && (!getNetwork().isExternal() || validateExternalNetwork(validator)); > In AttachNetworkToVdsGroupCommand the getNetwork() returns the network from Good catch. Fixed this and put more stuff in this class that didn't seem to hurt. It doesn't matter what you run isManagementNetwork() on, it just uses the name, which has to be the same for both in these commands. Changed to use another overload to make this clearer. Line 35: } Line 36: -- To view, visit http://gerrit.ovirt.org/32905 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3869fad7c00313626587ba28f867801795061f69 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzasp...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
