Alona Kaplan has posted comments on this change. Change subject: engine: Extract code common for cluster network attach/update ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/32905/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/NetworkClusterCommandBase.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/NetworkClusterCommandBase.java: Line 34: getNetwork In AttachNetworkToVdsGroupCommand the getNetwork() returns the network from the parameters. It means the isExternal may no be initialized properly. The persistent network should be used. It seems that !NetworkUtils.isManagementNetwork(getNetwork()) has the same problem in case the id is passed (and not the name). But it is the old behaviour so I"m not sure there was a bug or maybe I miss something. -- To view, visit http://gerrit.ovirt.org/32905 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3869fad7c00313626587ba28f867801795061f69 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzasp...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
