Liron Aravot has posted comments on this change. Change subject: core: export/import of diskless VM/VM with no snappable disks(#838937) ......................................................................
Patch Set 5: (5 inline comments) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ExportVmCommand.java Line 183: getDisksBasedOnImage(); will change Line 409: VM vm = getVm(); nop, beacuse the VM is still locked..so it can't be null when we try to get it again (unlock is performed on the next line) Line 444: this.endDefaultOps(vm); I agree that it should be changes to Operations instead of ops maybe (like Allon suggested). but i don't think that we should change it to a less general name. the intention of this method is to combine the end command operations that vm with snappable disks and vm's with no snappable disks share so that we can use it both on the end synchronously method and on the end asynchronously method, and not to be action specific.. Line 455: EndActionOnAllImageGroups(); from what I see , the method EndWithFailure() is used by the AsynchTaskManager to perform a cleanup in case of failure, in the case of sync operation, there are no tasks so we we won't reach EndWithFailure(); in case of exception on a vm with no snappable disks - the lock will be released by CommandBase - so it seems fine to me, let me know what you think. Line 456: VM vm = getVm(); nop, beacuse the VM is still locked..so it can't be null when we try to get it again (unlock is performed on the next line) -- To view, visit http://gerrit.ovirt.org/6379 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I77565ffd66134b44d15f66cfdfa97422e3c11fb2 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Ayal Baron <aba...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
