Liron Aravot has posted comments on this change.
Change subject: core: enable export/import of diskless VM/VM with no snappable
disks(#838937)
......................................................................
Patch Set 8: (4 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ExportVmCommand.java
Line 207: return !disksImages.isEmpty();
Done
Line 429: private void endCopyCollapseOperations(VM vm) {
I prefer to send the VM where possible instead of repeat VM vm = getVM(), it
reduces the times we call getVM() method, number of created references and
decouple the implementation from getVM() in case of future changes (for example
- seperate the implementation to different classes) - so I'd like to leave it
that way.
Line 441:
vm.setSnapshots(DbFacade.getInstance().getSnapshotDao().getAllWithConfiguration(getVm().getId()));
getSnapshotDao() is not defined for this class, may be changed in a separate
patch for the whole class.
Line 447: VmHandler.UnLockVm(vm.getId());
Done
--
To view, visit http://gerrit.ovirt.org/6379
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I77565ffd66134b44d15f66cfdfa97422e3c11fb2
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <lara...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Ayal Baron <aba...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Liron Aravot <lara...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com>
Gerrit-Reviewer: Tal Nisan <tni...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
