anmolbabu has posted comments on this change. Change subject: gluster-nagios-monitoring : Added a link to nagios home page ......................................................................
Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/33066/3/gluster-nagios-monitoring/src/js/trends.js File gluster-nagios-monitoring/src/js/trends.js: Line 160: getPnp4NagiosUrl : function() { Line 161: /* Line 162: * If pnp4NagiosUrl is available in configuration object, it uses the same url or else,it will assume engine url to be Line 163: * the pnp4nagios server. Line 164: */ > the check if(!pnp4NagiosUrl) is equivalent of it Oops sorry I probably misunderstood your comment. I mean I was thinking only about its member pnp4nagiosUrl and missed configObject. Will add it now.Thanks :) Line 165: var pnp4NagiosUrl = configObject.pnp4nagiosUrl; Line 166: if (!pnp4NagiosUrl) { Line 167: var port = ($location.port()) ? ":" + $location.port() : ""; Line 168: pnp4NagiosUrl = $location.protocol() + "://" + $location.host() + port; -- To view, visit http://gerrit.ovirt.org/33066 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4842868b77c6f328deab92fdf6641877e1061256 Gerrit-PatchSet: 3 Gerrit-Project: samples-uiplugins Gerrit-Branch: master Gerrit-Owner: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: anmolbabu <anb...@redhat.com> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
