anmolbabu has posted comments on this change. Change subject: gluster-nagios-monitoring : Added a link to nagios home page ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/33066/2/gluster-nagios-monitoring/src/js/trends.js File gluster-nagios-monitoring/src/js/trends.js: Line 480: $scope.graphs[i] = graphs[i]; Line 481: } Line 482: }; Line 483: $scope.goToNagios = function() { Line 484: var url = dataManager.getPnp4NagiosUrl() + "/nagios"; > What happens if configObject is null? Yes, you are right. The new check that I added is incorrect.I mean if configObject is null it essentially means that nagios and rhsc are co-existent which (Evaluating this is the intended purpose of getPnp4NagiosUrl()).I'll remove that incorrect newly introduced check in the getPnp4NagiosUrl(). Line 485: $window.open(url,'_blank'); Line 486: }; Line 487: $scope.getCustomGraphs = function() { Line 488: var startDate = $rootScope.startDate; -- To view, visit http://gerrit.ovirt.org/33066 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4842868b77c6f328deab92fdf6641877e1061256 Gerrit-PatchSet: 2 Gerrit-Project: samples-uiplugins Gerrit-Branch: master Gerrit-Owner: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: anmolbabu <anb...@redhat.com> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
