Lior Vernia has posted comments on this change. Change subject: frontend: refactoring: Generify Events and Listeners ......................................................................
Patch Set 5: (1 comment) http://gerrit.ovirt.org/#/c/32837/5//COMMIT_MSG Commit Message: Line 18: IEventListener#eventRaised method since this parameter, as opposed to Line 19: args, was rarely used and never in generic way (almost exclusively for object Line 20: equality checks) and the correct form given the above contravariance Line 21: feature would require unnecessary complication of all implementors Line 22: (Event<? extends T>). > Ok, just putting the <? extends T> in the interface definion seems to be wo I'm all for "keeping the interface honest" - but I think that would mean to drop the Event argument, not to leave it as a raw generic :) I'm okay with the compromise, will take a closer look at the code soon. Line 23: Line 24: Along the way there were encountered varios small oportunities to Line 25: generify several entity models and get rid of unnecessary casts. These Line 26: oportunities have been siezed. -- To view, visit http://gerrit.ovirt.org/32837 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icddf5780c00c985966e6ae956a401c3ede6a68e7 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbe...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Martin Betak <mbe...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
