Lior Vernia has posted comments on this change. Change subject: frontend: refactoring: Generify Events and Listeners ......................................................................
Patch Set 6: The changes to Event and IEventListener look good to me. However, this patch parametrizes quite a few IEventListener instances, sometimes in order to prevent unsafe casting, but mostly to remove IDE warnings. In doing so, it doesn't parametrize Event instances, so the warnings will remain. I don't see the value in such extensive refactoring if it doesn't end up removing the related warnings. -- To view, visit http://gerrit.ovirt.org/32837 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icddf5780c00c985966e6ae956a401c3ede6a68e7 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbe...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Martin Betak <mbe...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
