Ramesh N has posted comments on this change. Change subject: engine: VDS command to stop and delete geo-rep session ......................................................................
Patch Set 3: (2 comments) http://gerrit.ovirt.org/#/c/33006/3/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/DeleteGlusterVolumeGeoRepSessionVDSCommand.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/DeleteGlusterVolumeGeoRepSessionVDSCommand.java: Line 14: Line 15: @Override Line 16: protected void executeVdsBrokerCommand() { Line 17: status = getBroker().glusterVolumeGeoRepSessionDelete(getParameters().getVolumeName(), Line 18: getParameters().getSlaveHost(), I think u need to pass the slaveVolumeName here. Line 19: getParameters().getVolumeName()); Line 20: // Handle errors if any Line 21: proceedProxyReturnValue(); Line 22: http://gerrit.ovirt.org/#/c/33006/3/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/StopGlusterVolumeGeoRepSessionVDSCommand.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/StopGlusterVolumeGeoRepSessionVDSCommand.java: Line 13: Line 14: @Override Line 15: protected void executeVdsBrokerCommand() { Line 16: status = getBroker().glusterVolumeGeoRepSessionStop(getParameters().getVolumeName(), Line 17: getParameters().getSlaveHost(), U have to pass slaveVolumeName here. Line 18: getParameters().getVolumeName(), Line 19: getParameters().getForce()); Line 20: // Handle errors if any Line 21: proceedProxyReturnValue(); -- To view, visit http://gerrit.ovirt.org/33006 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib9f4a32783f2b119a56873b4c1290b10f8b208c8 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
