Sahina Bose has posted comments on this change. Change subject: engine: VDS command to stop and delete geo-rep session ......................................................................
Patch Set 2: (4 comments) http://gerrit.ovirt.org/#/c/33006/2/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllErrors.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllErrors.java: Line 400: GlusterLibgfapiException(4570), Line 401: GlfsStatvfsException(4571), Line 402: GlfsInitException(4572), Line 403: GlfsFiniException(4573), Line 404: GlusterGeoRepSessionDeleteFailedException(4594), > what about GlusterVolumeGeoRepSessionDeleteException and GlusterVolumeGeoRe Not sure I understand. These are the only 2 exceptions thrown by vdsm verbs . see http://gerrit.ovirt.org/#/c/17644 and http://gerrit.ovirt.org/#/c/17766 Line 405: GlusterVolumeGeoRepStopFailedException(4596), Line 406: GlusterVolumeGeoRepStatusFailed(4599), Line 407: GlusterVolumeGeoRepStatusDetailFailed(4600), Line 408: http://gerrit.ovirt.org/#/c/33006/2/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerWrapper.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerWrapper.java: Line 1230: } Line 1231: } Line 1232: Line 1233: Line 1234: > Un-necessary Done Line 1235: @Override Line 1236: public StatusOnlyReturnForXmlRpc vmUpdateDevice(String vmId, Map device) { Line 1237: try { Line 1238: Map<String, Object> xmlRpcReturnValue = Line 1423: Line 1424: @Override Line 1425: public StatusOnlyReturnForXmlRpc glusterVolumeGeoRepSessionDelete(String volumeName, String remoteHost, String remoteVolumeName) { Line 1426: try { Line 1427: return new StatusOnlyReturnForXmlRpc(vdsServer.glusterVolumeGeoRepSessionDelete(volumeName, remoteVolumeName, remoteVolumeName)); > remoteVolumeName passed twice. I feel remoteHost to be passed as second arg Done Line 1428: } catch (UndeclaredThrowableException ute) { Line 1429: throw new XmlRpcRunTimeException(ute); Line 1430: } Line 1431: } Line 1432: Line 1433: @Override Line 1434: public StatusOnlyReturnForXmlRpc glusterVolumeGeoRepSessionStop(String volumeName, String remoteHost, String remoteVolumeName, Boolean force) { Line 1435: try { Line 1436: return new StatusOnlyReturnForXmlRpc(vdsServer.glusterVolumeGeoRepSessionStop(volumeName, remoteVolumeName, remoteVolumeName, force)); > Same as above Done Line 1437: } catch (UndeclaredThrowableException ute) { Line 1438: throw new XmlRpcRunTimeException(ute); Line 1439: } Line 1440: } -- To view, visit http://gerrit.ovirt.org/33006 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib9f4a32783f2b119a56873b4c1290b10f8b208c8 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
