Sahina Bose has posted comments on this change. Change subject: engine : Bll command to start geo-rep session ......................................................................
Patch Set 2: (3 comments) http://gerrit.ovirt.org/#/c/32537/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterVolumeGeoRepStartCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterVolumeGeoRepStartCommand.java: Line 6: import org.ovirt.engine.core.common.vdscommands.VDSCommandType; Line 7: import org.ovirt.engine.core.common.vdscommands.VDSReturnValue; Line 8: import org.ovirt.engine.core.common.vdscommands.gluster.GlusterVolumeGeoRepSessionStartVDSParameters; Line 9: Line 10: public class GlusterVolumeGeoRepStartCommand extends GlusterVolumeCommandBase<GlusterVolumeGeoRepSessionStartParameters> { Extend from GeoRepSessionCommandBase in http://gerrit.ovirt.org/33038 Line 11: public GlusterVolumeGeoRepStartCommand(GlusterVolumeGeoRepSessionStartParameters params) { Line 12: super(params); Line 13: } Line 14: Line 21: @Override Line 22: protected void executeCommand() { Line 23: GlusterVolumeGeoRepSessionStartParameters parameters = getParameters(); Line 24: setGlusterVolumeId(parameters.getVolumeId()); Line 25: VDSReturnValue returnValue = runVdsCommand(VDSCommandType.GlusterVolumeGeoRepStart, new GlusterVolumeGeoRepSessionStartVDSParameters(upServer.getId(), getGlusterVolumeName(), parameters.getSlaveVolumeName(), parameters.getSlaveHost())); You need to validate that these parameters are present in the canDoAction method. Line 26: setSucceeded(returnValue.getSucceeded()); Line 27: if(! getSucceeded()) { Line 28: handleVdsError(AuditLogType.GLUSTER_VOLUME_GEO_REP_START_FAILED_EXCEPTION, returnValue.getVdsError().getMessage()); Line 29: } Line 25: VDSReturnValue returnValue = runVdsCommand(VDSCommandType.GlusterVolumeGeoRepStart, new GlusterVolumeGeoRepSessionStartVDSParameters(upServer.getId(), getGlusterVolumeName(), parameters.getSlaveVolumeName(), parameters.getSlaveHost())); Line 26: setSucceeded(returnValue.getSucceeded()); Line 27: if(! getSucceeded()) { Line 28: handleVdsError(AuditLogType.GLUSTER_VOLUME_GEO_REP_START_FAILED_EXCEPTION, returnValue.getVdsError().getMessage()); Line 29: } If succeeded, shouldn't the entry be created in the database? Line 30: } Line 31: Line 32: @Override Line 33: public AuditLogType getAuditLogTypeValue() { -- To view, visit http://gerrit.ovirt.org/32537 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib74c515d23218bb2e30403e0e0042c84b74dc2bb Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
