Sahina Bose has posted comments on this change.

Change subject: engine : Bll command to start geo-rep session
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.ovirt.org/#/c/32537/2/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/gluster/GlusterVolumeGeoRepSessionStartParameters.java
File 
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/gluster/GlusterVolumeGeoRepSessionStartParameters.java:

Line 1: package org.ovirt.engine.core.common.action.gluster;
Line 2: 
Line 3: import org.ovirt.engine.core.compat.Guid;
Line 4: 
Line 5: public class GlusterVolumeGeoRepSessionStartParameters extends 
GlusterVolumeParameters{
Can you rename this as GlusterVolumeGeoRepSessionParameters, so that this can 
be reused?
Line 6: 
Line 7:     private static final long serialVersionUID = -881348048838907389L;
Line 8: 
Line 9:     private String slaveVolumeName;


-- 
To view, visit http://gerrit.ovirt.org/32537
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib74c515d23218bb2e30403e0e0042c84b74dc2bb
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: anmolbabu <anb...@redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com>
Gerrit-Reviewer: Ramesh N <rnach...@redhat.com>
Gerrit-Reviewer: Sahina Bose <sab...@redhat.com>
Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to