Gilad Chaplik has posted comments on this change. Change subject: frontend: add numa support to VM dialog ......................................................................
Patch Set 6: (1 comment) http://gerrit.ovirt.org/#/c/32913/6/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/builders/vm/NumaUnitToVmBaseBuilder.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/builders/vm/NumaUnitToVmBaseBuilder.java: Line 47: private void updateMemory(VmNumaNode vmNumaNode, int memSize) { Line 48: vmNumaNode.setMemTotal(memSize); Line 49: } Line 50: Line 51: private void updateCpus(VmNumaNode vmNumaNode, int coresPerNode, Integer cpuCount) { > I'd say you will not achieve here what you intended - the Integer is immuta right! thanks, I'm going to upload sht completely else in the cpu area... will ping you once that's in so you can take a look :-) Line 52: List<Integer> coreList = new ArrayList<Integer>(); Line 53: for (int j = 0; j < coresPerNode; j++, cpuCount++) { Line 54: coreList.add(cpuCount); Line 55: } -- To view, visit http://gerrit.ovirt.org/32913 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I05b83028b722088e39ad7156c77ad4eb479dc241 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
