Tomas Jelinek has posted comments on this change. Change subject: frontend: add numa support to VM dialog ......................................................................
Patch Set 4: Code-Review+2 (4 comments) only very minor comments - giving +2 and please fix on rebase http://gerrit.ovirt.org/#/c/32913/4/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java: Line 1938: Line 1939: @DefaultStringValue("Tune Mode") Line 1940: String numaTunaModeLabel(); Line 1941: Line 1942: @DefaultStringValue("Numa Node Count") I'd say the "Numa" should be capitalized to "NUMA" also here (same as the other two labels) Line 1943: String numaNodeCountLabel(); Line 1944: Line 1945: @DefaultStringValue("Configure NUMA:") Line 1946: String numaSectionLabel(); http://gerrit.ovirt.org/#/c/32913/4/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java: Line 1065: } Line 1066: Line 1067: }); Line 1068: Line 1069: numaInfoIcon = new InfoIcon(SafeHtmlUtils.fromTrustedString(""), resources); ////$NON-NLS-1$ too much slashes (two is enough) ;) Line 1070: } Line 1071: Line 1072: /** Line 1073: * There are two editors which edits the same entity - in the correct subclass make sure that the correct one's Line 1480: private void setNumaInfoMsg(String message) { Line 1481: if (message == null) { Line 1482: message = ""; //$NON-NLS-1$ Line 1483: } Line 1484: numaInfoIcon.setText(SafeHtmlUtils.fromTrustedString(message)); normally we use italic text for info icons like this: numaInfoIcon.setText(applicationTemplates.italicText(message)); Line 1485: } Line 1486: Line 1487: private void enableNumaFields(boolean enabled) { Line 1488: numaNodeCount.setEnabled(enabled); http://gerrit.ovirt.org/#/c/32913/4/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/numa/VmNumaSupportModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/numa/VmNumaSupportModel.java: Line 23: } else { Line 24: VM removeVm = null; Line 25: for (VM inerVm : vmsWithvNumaNodeList) { Line 26: if (inerVm.getId().equals(vm.getId())) { Line 27: removeVm = inerVm; s/iner/inner Line 28: break; Line 29: } Line 30: } Line 31: vmsWithvNumaNodeList.remove(removeVm); -- To view, visit http://gerrit.ovirt.org/32913 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I05b83028b722088e39ad7156c77ad4eb479dc241 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
