Alexander Wels has posted comments on this change.

Change subject: userportal,webadmin: messages locale unit test
......................................................................


Patch Set 2: Verified+1

Fixed the following scenario that was passing while it should be failing:

  @DefaultMessage("{0} is {1} a {2}")
  String blah(String aa, @Optional String bb, String cc);

With

  blah={0} ist {1}

Since 1 is option and 2 is not, this should fail, while like Vojtech said the 
following should pass:

  blah={0} ist {2}

-- 
To view, visit http://gerrit.ovirt.org/32995
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icda389f2ca08e9d3b7515bb4a0dc1213bc91aeef
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alexander Wels <aw...@redhat.com>
Gerrit-Reviewer: Alexander Wels <aw...@redhat.com>
Gerrit-Reviewer: Einav Cohen <eco...@redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to