Maor Lipchuk has submitted this change and it was merged. Change subject: core: Remove disk from snapshots (#828192) ......................................................................
core: Remove disk from snapshots (#828192) https://bugzilla.redhat.com/828192 When a disk is removed all its snapshots are removed. However, they are not removed from the snapshot's configuration - instead, they are marked as ILLEGAL (upon reading!). Unfortunately, many flows disregard illegal snapshot disks (e.g., BZ 828192), which leads to a bunch of broken flows. This patch proposes a different approach - since the disk is removed entirely, with its snapshots, it should also be removed from the snapshots' configuration, as if it never existed. Change-Id: I97dedb9b8e8cd4dd0cae6c7b01d4b5678ba0a2d0 Signed-off-by: Allon Mureinik <amure...@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveImageCommand.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RemoveImageCommandTest.java 2 files changed, 225 insertions(+), 28 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, but someone else must approve Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6025 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I97dedb9b8e8cd4dd0cae6c7b01d4b5678ba0a2d0 Gerrit-PatchSet: 22 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Ayal Baron <aba...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
