Juan Hernandez has posted comments on this change.
Change subject: build: Add artifactProvided to module definition
......................................................................
Patch Set 1:
I see. I think that a better way to achieve what you want is to check if the
"artifactId" (or "groupId", or both) are null, and then do nothing in the
"createModule" method:
private void createModule(Module module) ... {
// If the module doesn't specify an artifact then we don't need to
// do anything:
if (module.getArtifactId() == null) {
return;
}
// Create the slot directory:
...
}
That way, when specifying one of these modules you don't need to add the
dependency to the <dependencies> section of the POM and you don't need to put a
dummy artifatId or groupId in the <module>:
<!-- This is a module without artifacts: -->
<module>
<!-- Note that there is no artifactId or groupId element. -->
<moduleName>whatever</moduleName>
</module>
--
To view, visit http://gerrit.ovirt.org/32848
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I71b68b1d1d4222ffba91be957cb764a54f658519
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <mper...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Martin Peřina <mper...@redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
