Martin Peřina has uploaded a new change for review.

Change subject: tools: Replace oVirt logger with slf4j as frontend in 
engine-manage-domains
......................................................................

tools: Replace oVirt logger with slf4j as frontend in engine-manage-domains

Replaces oVirt logger with slf4j as logging frontend in classes which are
used in engine-manage-domains tool.

Change-Id: I82996f8f6ad3b7111b5bb36d46a395d94dd70e80
Bug-Url: https://bugzilla.redhat.com/1109871
Signed-off-by: Martin Perina <[email protected]>
---
M 
backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/utils/dns/DnsSRVLocator.java
1 file changed, 5 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/51/32851/1

diff --git 
a/backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/utils/dns/DnsSRVLocator.java
 
b/backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/utils/dns/DnsSRVLocator.java
index 9b03491..a27fa4f 100644
--- 
a/backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/utils/dns/DnsSRVLocator.java
+++ 
b/backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/utils/dns/DnsSRVLocator.java
@@ -18,8 +18,8 @@
 import javax.naming.directory.DirContext;
 import javax.naming.spi.NamingManager;
 
-import org.ovirt.engine.core.utils.log.Log;
-import org.ovirt.engine.core.utils.log.LogFactory;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
 
 /**
  * Utility class to query DNS SRV records, and return results according to the 
priority/weights algorithm as specified
@@ -27,6 +27,7 @@
  *
  */
 public class DnsSRVLocator {
+    private static final Logger log = 
LoggerFactory.getLogger(DnsSRVLocator.class);
 
     private static final String DNS_QUERY_PREFIX = "dns:///";
     private static final String SRV_RECORD = "SRV";
@@ -215,7 +216,7 @@
         try {
             return getService(domain, dnsQuery.toString());
         } catch (Exception ex) {
-            log.errorFormat("Error: could not find DNS SRV record name: 
{0}.{1}.{2}.\nException message is: {3}\n" +
+            log.error("Error: could not find DNS SRV record name: 
{}.{}.{}.\nException message is: {}\n" +
                     "Possible causes: missing DNS entries in the DNS server or 
DNS resolving" +
                     " issues from engine-core machine.\nPlease Ensure correct 
DNS entries exist in the DNS server" +
                     " and ensure the DNS server is reachable from the 
engine-core machine.",
@@ -381,7 +382,7 @@
             sb.append(":").append(port);
             return new SrvRecord(priority, weight, sb.toString());
         } catch (InputMismatchException ex) {
-            log.errorFormat("the record {0} has invalid format", recordStr);
+            log.error("the record {} has invalid format", recordStr);
 
             // In case there is a parsing error, the invalid record constant is
             // returned
@@ -418,7 +419,4 @@
         uriSB.append("://").append(hostname).append(":").append(port);
         return new URI(uriSB.toString());
     }
-
-    private static final Log log = LogFactory.getLog(DnsSRVLocator.class);
-
 }


-- 
To view, visit http://gerrit.ovirt.org/32851
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I82996f8f6ad3b7111b5bb36d46a395d94dd70e80
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to