Alexander Wels has posted comments on this change. Change subject: aaa: do not display non password authn profiles within login ......................................................................
Patch Set 1: Code-Review+1 (1 comment) Looks good to me too, one minor nitpick. I can give +2 as well. http://gerrit.ovirt.org/#/c/32732/1/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/aaa/ProfileEntry.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/aaa/ProfileEntry.java: Line 7: private static final long serialVersionUID = 8525199877264821199L; Line 8: Line 9: private String profile; Line 10: private String authz; Line 11: boolean supportsPasswordAuthentication; All of these can be final. Line 12: Line 13: public ProfileEntry() { Line 14: } Line 15: -- To view, visit http://gerrit.ovirt.org/32732 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I74df82dcead1b88124b44cbec2ea43ef85768fce Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
