Yair Zaslavsky has posted comments on this change. Change subject: aaa: do not display non password authn profiles within login ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/32732/1/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/LoginModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/LoginModel.java: Line 203: loginModel.getProfile().setItems(domains); Line 204: Line 205: } Line 206: }; Line 207: AsyncDataProvider.getInstance().getAAAProfilesListViaPublic(_asyncQuery, true); minor comment - via public means this is a public query, no authn/authz is required in order to run the query, One of the few scenarios we use this is in order to get the profiles for the login sceen. Either remove the ViaPublic or remove the boolean from the signature, IMHO having them both is redundant. Line 208: } Line 209: Line 210: public void login() Line 211: { -- To view, visit http://gerrit.ovirt.org/32732 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I74df82dcead1b88124b44cbec2ea43ef85768fce Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
