Oved Ourfali has posted comments on this change. Change subject: core: monitoring - split VDS and VMs monitoring apart ......................................................................
Patch Set 8: (1 comment) http://gerrit.ovirt.org/#/c/27920/8/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmsMonitoring.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmsMonitoring.java: Line 95: private final List<VmDeviceId> removedDeviceIds = new ArrayList<>(); Line 96: private final List<LUNs> vmLunDisksToSave = new ArrayList<>(); Line 97: private final List<Guid> _vmsToRerun = new ArrayList<>(); Line 98: private final List<Guid> _autoVmsToRun = new ArrayList<>(); Line 99: private final List<VmStatic> _externalVmsToAdd = new ArrayList<>(); are the underscores removed in future patches? Line 100: private final Map<Guid, VmJob> vmJobsToUpdate = new HashMap<>(); Line 101: private final List<Guid> vmJobIdsToRemove = new ArrayList<>(); Line 102: private final List<Guid> existingVmJobIds = new ArrayList<>(); Line 103: -- To view, visit http://gerrit.ovirt.org/27920 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic2f4acb9ad6acd07552d4aabe97cd2a63a328b75 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Liran Zelkha <lzel...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
