Omer Frenkel has posted comments on this change. Change subject: core: monitoring - split VDS and VMs monitoring apart ......................................................................
Patch Set 8: (2 comments) http://gerrit.ovirt.org/#/c/27920/8/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/HostMonitoring.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/HostMonitoring.java: Line 56: private final VDS _vds; Line 57: Line 58: private boolean processHardwareCapsNeeded; Line 59: private boolean refreshedCapabilities = false; Line 60: VmsMonitoring vmsMonitoring; please add field modifier (private?) Line 61: private static Map<Guid, Long> hostDownTimes = new HashMap<>(); Line 62: private boolean vdsMaintenanceTimeoutOccurred; Line 63: Line 64: private static final Log log = LogFactory.getLog(HostMonitoring.class); Line 469: } Line 470: // get statistics data, images checks and vm_count data (dynamic) Line 471: VDSReturnValue statsReturnValue = getResourceManager().runVdsCommand(VDSCommandType.GetStats, Line 472: new VdsIdAndVdsVDSCommandParametersBase(_vds)); Line 473: getResourceManager().getEventListener().updateSchedulingStats(_vds); why did you change getEventListener().updateSchedulingStats(_vds); to getResourceManager().getEventListener().updateSchedulingStats(_vds); ? Line 474: if (!statsReturnValue.getSucceeded() Line 475: && statsReturnValue.getExceptionObject() != null) { Line 476: VDSNetworkException ex = Line 477: (VDSNetworkException) ((statsReturnValue.getExceptionObject() instanceof VDSNetworkException) -- To view, visit http://gerrit.ovirt.org/27920 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic2f4acb9ad6acd07552d4aabe97cd2a63a328b75 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Liran Zelkha <lzel...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
