Allon Mureinik has posted comments on this change. Change subject: core: ImportVmCommand storage allocation checks ......................................................................
Patch Set 12: Code-Review-1 (1 comment) Generally +2, but IIUC this may break the serialization - please fix this (see inline) and verify http://gerrit.ovirt.org/#/c/32258/12/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/DiskImageBase.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/DiskImageBase.java: Line 57: Line 58: public void setSize(long size) { Line 59: getImage().setSize(size); Line 60: } Line 61: Missing @JSonIgnore so we don't break [de]serialization Line 62: public long getCapacity() { Line 63: return getSize(); Line 64: } Line 65: -- To view, visit http://gerrit.ovirt.org/32258 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifbb1d985f9afa476452d1d2b78be1fd18c128c8f Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vered Volansky <vvola...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
