Arik Hadas has posted comments on this change. Change subject: core: ImportVmCommand storage allocation checks ......................................................................
Patch Set 10: Code-Review+1 (1 comment) Minor comment, letting Allon to decide if the method should be renamed. Other than that, looks good to me, assuming the validation will be fixed in latter patch to actually be correct as the commit message says :) http://gerrit.ovirt.org/#/c/32258/10/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java: Line 490: } Line 491: return true; Line 492: } Line 493: Line 494: private StorageDomain updateStorageDomainForMemoryVolumes(Snapshot snapshot, List<DiskImage> disksList) { > disksList is updated. well, neither the storage domain nor memory volume is updated here so I think the name still doesn't reflect what the method does.. Line 495: VM vm = getVmFromSnapshot(snapshot); Line 496: List<DiskImage> memoryDisksList = MemoryUtils.createDiskDummies(vm.getTotalMemorySizeInBytes(), MemoryUtils.META_DATA_SIZE_IN_BYTES); Line 497: StorageDomain storageDomain = VmHandler.findStorageDomainForMemory(getParameters().getStoragePoolId(), memoryDisksList); Line 498: disksList.addAll(memoryDisksList); -- To view, visit http://gerrit.ovirt.org/32258 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifbb1d985f9afa476452d1d2b78be1fd18c128c8f Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vered Volansky <vvola...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
