Omer Frenkel has posted comments on this change. Change subject: core: VdsManager - no need to cache config values ......................................................................
Patch Set 11: (1 comment) http://gerrit.ovirt.org/#/c/27375/11/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java: Line 85: private boolean isSetNonOperationalExecuted; Line 86: private MonitoringStrategy monitoringStrategy; Line 87: private EngineLock monitoringLock; Line 88: private int VDS_DURING_FAILURE_TIMEOUT_IN_MINUTES = Config Line 89: .<Integer> getValue(ConfigValues.TimeToReduceFailedRunOnVdsInMinutes); is this still in use? Line 90: private boolean initialized; Line 91: private IVdsServer _vdsProxy; Line 92: private boolean mBeforeFirstRefresh = true; Line 93: private VdsUpdateRunTimeInfo _vdsUpdater; -- To view, visit http://gerrit.ovirt.org/27375 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icfb5a1641038742dd848ee67cb0fe53ce16b7909 Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <[email protected]> Gerrit-Reviewer: Liran Zelkha <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
