Roy Golan has posted comments on this change. Change subject: core: VdsManager - no need to cache config values ......................................................................
Patch Set 11: (1 comment) http://gerrit.ovirt.org/#/c/27375/11/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java: Line 85: private boolean isSetNonOperationalExecuted; Line 86: private MonitoringStrategy monitoringStrategy; Line 87: private EngineLock monitoringLock; Line 88: private int VDS_DURING_FAILURE_TIMEOUT_IN_MINUTES = Config Line 89: .<Integer> getValue(ConfigValues.TimeToReduceFailedRunOnVdsInMinutes); > is this still in use? I removed it as well in a I90e26c1a2db4d51f5bd13cf39a59593579fa7648 will fixup as it is related to this patch Line 90: private boolean initialized; Line 91: private IVdsServer _vdsProxy; Line 92: private boolean mBeforeFirstRefresh = true; Line 93: private VdsUpdateRunTimeInfo _vdsUpdater; -- To view, visit http://gerrit.ovirt.org/27375 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icfb5a1641038742dd848ee67cb0fe53ce16b7909 Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Liran Zelkha <lzel...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
