Gilad Chaplik has posted comments on this change. Change subject: ui: Adding fields validation in addHost form ......................................................................
Patch Set 12: Verified+1 Code-Review+1 (1 comment) http://gerrit.ovirt.org/#/c/31178/12/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostModel.java: Line 1654: if (Boolean.TRUE.equals(getIsDiscorveredHosts().getEntity())) { Line 1655: getUserPassword().validateEntity(new IValidation[] { Line 1656: new NotEmptyValidation(), Line 1657: new LengthValidation(255) Line 1658: }); can be fixed in a later patch: when 'ssh public key' enabled, it hides pw input and prevents user from seeing the error. Line 1659: getExternalComputeResource().validateEntity(new IValidation[] {new NotEmptyValidation()}); Line 1660: getExternalHostGroups().validateEntity(new IValidation[] {new NotEmptyValidation()}); Line 1661: } Line 1662: -- To view, visit http://gerrit.ovirt.org/31178 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icfc3e500ad06728fc8c410baa13405633fc90da2 Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
