Oved Ourfali has posted comments on this change. Change subject: ui: Adding fields validation in addHost form ......................................................................
Patch Set 9: Code-Review-1 (1 comment) http://gerrit.ovirt.org/#/c/31178/9/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostModel.java: Line 1678: new NotEmptyValidation(), Line 1679: new LengthValidation(255), Line 1680: new HostAddressValidation() }); Line 1681: Line 1682: if (getIsDiscorveredHosts().getEntity()) { we will have an issue here as well, right? Line 1683: getUserPassword().validateEntity(new IValidation[] { Line 1684: new NotEmptyValidation(), Line 1685: new LengthValidation(255) Line 1686: }); -- To view, visit http://gerrit.ovirt.org/31178 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icfc3e500ad06728fc8c410baa13405633fc90da2 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
