Moti Asayag has posted comments on this change. Change subject: engine: integrate CidrValidation to backend ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/32540/1/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/validation/CidrConstraint.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/validation/CidrConstraint.java: Line 27: } Line 28: return true; Line 29: } Line 30: Line 31: } or you can make it look like: @Override public boolean isValid(String cidr, ConstraintValidatorContext context) { if (!CidrValidator.isCidrFormatValid(cidr)) { return failWith(context, "BAD_CIDR_FORMAT"); } if (!CidrValidator.isCidrValidNetworkAddress(cidr)) { return failWith(context, "CIDR_NOT_NETWORK_ADDRESS"); } return true; } protected boolean failWith(ConstraintValidatorContext context, String message) { context.disableDefaultConstraintViolation(); context.buildConstraintViolationWithTemplate(message) .addNode("cidr") .addConstraintViolation(); return false; } -- To view, visit http://gerrit.ovirt.org/32540 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib4dc94cc350dc03195c3f24ba783036592e3c03e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eliraz Levi <el...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Eliraz Levi <el...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
