[Engine-patches] Change in ovirt-engine[master]: engine: integrate CidrValidation to backend

[masayag]

Moti Asayag has posted comments on this change.

Change subject: engine: integrate CidrValidation to backend
......................................................................


Patch Set 3:

(2 comments)

http://gerrit.ovirt.org/#/c/32540/3/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/ExternalSubnet.java
File 
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/ExternalSubnet.java:

Line 18:     private String id;
Line 19: 
Line 20:     private String name;
Line 21: 
Line 22:     @Cidr
please add CreateEntity group so update/remove subnet won't fail, i.e.:
  @Cidr(groups = { CreateEntity.class })

and also add to AddSubnetToProviderCommand:
    @Override
    protected List<Class<?>> getValidationGroups() {
        addValidationGroup(CreateEntity.class);
        return super.getValidationGroups();
    }
Line 23:     private String cidr;
Line 24: 
Line 25:     private IpVersion ipVersion;
Line 26: 


http://gerrit.ovirt.org/#/c/32540/3/backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/utils/CidrAnnotationTest.java
File 
backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/utils/CidrAnnotationTest.java:

Line 13: import org.junit.runner.RunWith;
Line 14: import org.junit.runners.Parameterized;
Line 15: import org.ovirt.engine.core.common.validation.CidrValidatorTest;
Line 16: import org.ovirt.engine.core.common.validation.annotation.Cidr;
Line 17: 
see 
http://gerrit.ovirt.org/#/c/32564/2/backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/utils/MacAddressPatternTest.java,cm
for verifying the correct message is returned in case of a failure.
Line 18: @RunWith(Parameterized.class)
Line 19: public class CidrAnnotationTest {
Line 20: 
Line 21:     private String cidr;


-- 
To view, visit http://gerrit.ovirt.org/32540
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib4dc94cc350dc03195c3f24ba783036592e3c03e
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eliraz Levi <el...@redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com>
Gerrit-Reviewer: Eliraz Levi <el...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches