Daniel Erez has abandoned this change. Change subject: core: AddVmTemplate - check perms on target SDs ......................................................................
Abandoned Since creating a template requires CREATE_TEMPLATE action group on the entire data-center, adding granularity for storage domains (e.g. by checking against CREATE_DISK action group) seems currently redundant/over-complexed. Adding it, essentially means granting current TemplateAdmins/TemplateCreators/etc permissions for CREATE_DISK on the entire DC (to keep current behavior), or, require them to manually grant the needed permissions. Hence, it looks like a best of a bad lot to keep the current design as is and revisit on permissions mechanism overall simplification. -- To view, visit http://gerrit.ovirt.org/32199 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: Ib6b7913a6a456e8df1b8962a96757c4f77e0939f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches