Omer Frenkel has posted comments on this change. Change subject: core: AddVmTemplate - check perms on target SDs ......................................................................
Patch Set 1: Sorry Daniel, you are right, i missed the 'else' part. the use-case i (and Michal) had in mind, is that if we want to block user to use only domains X & Y and not Z, to allow this granularity we need to add a check on the domains (not sure if create_template or add_disk, but something) if there is no such requirement, maybe we can leave it for now.. -- To view, visit http://gerrit.ovirt.org/32199 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib6b7913a6a456e8df1b8962a96757c4f77e0939f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
