Sandro Bonazzola has posted comments on this change. Change subject: Update engine's mgmt net to have the correct vlan id ......................................................................
Patch Set 3: (2 comments) Just 2 minor comments for the code. Going to verify this. http://gerrit.ovirt.org/#/c/32269/3/src/ovirt_hosted_engine_setup/network.py File src/ovirt_hosted_engine_setup/network.py: Line 20: Line 21: """ Line 22: host networking utilities Line 23: """ Line 24: Please use 2 new lines here Line 25: from vdsm import netinfo Line 26: Line 27: Line 28: def vds_capabilities(conn): Line 66: attrs['netmask'] = port_info['netmask'] Line 67: gateway = port_info.get('gateway') Line 68: if gateway is not None: Line 69: attrs['gateway'] = gateway Line 70: return attrs Please add # vim: expandtab tabstop=4 shiftwidth=4 at the end of the file -- To view, visit http://gerrit.ovirt.org/32269 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ica4c5804395d364438f1e142387376cc7adc7172 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon <asegu...@redhat.com> Gerrit-Reviewer: Antoni Segura Puimedon <asegu...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
