Sandro Bonazzola has posted comments on this change.
Change subject: Update engine's mgmt net to have the correct vlan id
......................................................................
Patch Set 2: Verified-1 Code-Review-1
(1 comment)
Fails with:
# OTOPI_DEBUG=1 hosted-engine --deploy
Loading plugin group otopi
Loading plugin otopi:system (/usr/share/otopi/plugins/otopi/system)
Loading plugin otopi:dialog (/usr/share/otopi/plugins/otopi/dialog)
Loading plugin otopi:core (/usr/share/otopi/plugins/otopi/core)
Loading plugin otopi:network (/usr/share/otopi/plugins/otopi/network)
Loading plugin otopi:packagers (/usr/share/otopi/plugins/otopi/packagers)
Loading plugin otopi:services (/usr/share/otopi/plugins/otopi/services)
Loading plugin group ovirt-hosted-engine-setup
Loading plugin ovirt-hosted-engine-setup:libvirt
(/usr/share/ovirt-hosted-engine-setup/scripts/../plugins/ovirt-hosted-engine-setup/libvirt)
Loading plugin ovirt-hosted-engine-setup:engine
(/usr/share/ovirt-hosted-engine-setup/scripts/../plugins/ovirt-hosted-engine-setup/engine)
***L:ERROR Internal error: No module named network
Traceback (most recent call last):
File "/usr/lib/python2.6/site-packages/otopi/__main__.py", line 94, in main
installer.execute()
File "/usr/lib/python2.6/site-packages/otopi/main.py", line 159, in execute
sys.exc_info()[2],
File "/usr/lib/python2.6/site-packages/otopi/util.py", line 93, in
raiseExceptionInformation
exec('raise info[1], None, info[2]')
File "/usr/lib/python2.6/site-packages/otopi/main.py", line 153, in execute
self.context.loadPlugins()
File "/usr/lib/python2.6/site-packages/otopi/context.py", line 506, in
loadPlugins
self._loadPluginGroups(plugindir, needgroups, loadedgroups)
File "/usr/lib/python2.6/site-packages/otopi/context.py", line 123, in
_loadPluginGroups
self._loadPlugins(path, path, groupname)
File "/usr/lib/python2.6/site-packages/otopi/context.py", line 80, in
_loadPlugins
self._loadPlugins(base, d, groupname)
File "/usr/lib/python2.6/site-packages/otopi/context.py", line 111, in
_loadPlugins
os.path.basename(path),
File "/usr/lib/python2.6/site-packages/otopi/util.py", line 117, in loadModule
mod_desc
File
"/usr/share/ovirt-hosted-engine-setup/scripts/../plugins/ovirt-hosted-engine-setup/engine/__init__.py",
line 30, in <module>
from . import add_host
File
"/usr/share/ovirt-hosted-engine-setup/scripts/../plugins/ovirt-hosted-engine-setup/engine/add_host.py",
line 54, in <module>
from ovirt_hosted_engine_setup.network import bridge
PluginLoadException: No module named network
http://gerrit.ovirt.org/#/c/32269/2/src/plugins/ovirt-hosted-engine-setup/engine/add_host.py
File src/plugins/ovirt-hosted-engine-setup/engine/add_host.py:
Line 50: from vdsm import vdscli
Line 51:
Line 52:
Line 53: from ovirt_hosted_engine_setup import constants as ohostedcons
Line 54: from ovirt_hosted_engine_setup.network import bridge
you can't import a plugin within another plugin.
if you need a network module you need to create it in
src/ovirt_hosted_engine_setup
Line 55:
Line 56:
Line 57: _ = lambda m: gettext.dgettext(message=m,
domain='ovirt-hosted-engine-setup')
Line 58:
--
To view, visit http://gerrit.ovirt.org/32269
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ica4c5804395d364438f1e142387376cc7adc7172
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <asegu...@redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegu...@redhat.com>
Gerrit-Reviewer: Lior Vernia <lver...@redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
