Roy Golan has posted comments on this change.

Change subject: core: NPE when getVMFullList returns no vm information
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.ovirt.org/#/c/32276/3/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VMListReturnForXmlRpc.java
File 
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VMListReturnForXmlRpc.java:

Line 17:     private static final String VM_LIST = "vmList";
Line 18:     private static final Map<String, Object>[] EMPTY_ARRAY_MAP = new 
HashMap[0];
Line 19: 
Line 20:     public StatusForXmlRpc mStatus;
Line 21:     public Map<String, Object>[] mVmList = EMPTY_ARRAY_MAP;
same naming comment as in master patch
Line 22: 
Line 23:     public VMListReturnForXmlRpc(Map<String, Object> innerMap) {
Line 24:         mStatus = new StatusForXmlRpc((Map<String, Object>) 
innerMap.get(STATUS));
Line 25:         Object[] temp = (Object[]) innerMap.get(VM_LIST);


-- 
To view, visit http://gerrit.ovirt.org/32276
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifa1971f1181489e50877d080aec36ebc6d715f74
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Piotr Kliczewski <piotr.kliczew...@gmail.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com>
Gerrit-Reviewer: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to