Roy Golan has posted comments on this change. Change subject: core: NPE when getVMFullList returns no vm information ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/32276/2/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VMListReturnForXmlRpc.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VMListReturnForXmlRpc.java: Line 16: private static final String STATUS = "status"; Line 17: private static final String VM_LIST = "vmList"; Line 18: Line 19: public StatusForXmlRpc mStatus; Line 20: public Map<String, Object>[] mVmList = new HashMap[0]; good. I'd go step further and put public static final EMPTY_MAP_ARRAY = new HashMap[0] and just skip the allocation each time Line 21: Line 22: public VMListReturnForXmlRpc(Map<String, Object> innerMap) { Line 23: mStatus = new StatusForXmlRpc((Map<String, Object>) innerMap.get(STATUS)); Line 24: Object[] temp = (Object[]) innerMap.get(VM_LIST); -- To view, visit http://gerrit.ovirt.org/32276 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifa1971f1181489e50877d080aec36ebc6d715f74 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
