Simone Tiraboschi has posted comments on this change. Change subject: packaging: setup: Improoving support for unattended setup ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/32292/2/packaging/setup/plugins/ovirt-engine-setup/websocket_proxy/pki.py File packaging/setup/plugins/ovirt-engine-setup/websocket_proxy/pki.py: Line 337: remote_engine_host = self.dialog.queryString( Line 338: name='REMOTE_ENGINE_HOST', Line 339: note=_( Line 340: 'Please provide the FQDN or IP ' Line 341: 'of the remote engine host: ' > On a second thought, I am not sure I can accept that. Did Alon accept that? He suggested that to me. See comment on line 207 here: http://gerrit.ovirt.org/#/c/28534/11/packaging/setup/plugins/ovirt-engine-setup/websocket_proxy/config.py and on line 384 there: http://gerrit.ovirt.org/#/c/28534/18/packaging/setup/plugins/ovirt-engine-setup/websocket_proxy/config.py I'm not validating this cert at download time cause I trust that the wsp daemon will validate that at occasion validating the tickets. Line 342: ), Line 343: prompt=True, Line 344: ) Line 345: -- To view, visit http://gerrit.ovirt.org/32292 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic20c9fc375867fdfb6d299b3d09cd7fc14d380bc Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Lev Veyde <lve...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
