Simone Tiraboschi has posted comments on this change. Change subject: packaging: setup: Improoving support for unattended setup ......................................................................
Patch Set 2: (2 comments) http://gerrit.ovirt.org/#/c/32292/2/packaging/setup/plugins/ovirt-engine-setup/websocket_proxy/pki.py File packaging/setup/plugins/ovirt-engine-setup/websocket_proxy/pki.py: Line 323: if self._on_separate_h: Line 324: self.logger.debug('Acquiring engine.crt from the engine') Line 325: remote_engine_host = self.environment[ Line 326: owspcons.ConfigEnv.REMOTE_ENGINE_HOST Line 327: ] > _interactive = False Done Line 328: if remote_engine_host is None: Line 329: _interactive = True Line 330: else: Line 331: _interactive = False Line 337: remote_engine_host = self.dialog.queryString( Line 338: name='REMOTE_ENGINE_HOST', Line 339: note=_( Line 340: 'Please provide the FQDN or IP ' Line 341: 'of the remote engine host: ' > Does IP works? Doesn't need to be validated with pki or ssl cert? It works cause I'm downloading it from http and so we don't have https ssl validation; than I'm not validating the CN of that cert. But I've to admit that is not that elegant. Line 342: ), Line 343: prompt=True, Line 344: ) Line 345: -- To view, visit http://gerrit.ovirt.org/32292 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic20c9fc375867fdfb6d299b3d09cd7fc14d380bc Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Lev Veyde <lve...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
