Alon Bar-Lev has posted comments on this change. Change subject: core: Adjust websockify to the new API ......................................................................
Patch Set 1: (2 comments) http://gerrit.ovirt.org/#/c/32138/1/packaging/services/ovirt-websocket-proxy/ovirt-websocket-proxy.py File packaging/services/ovirt-websocket-proxy/ovirt-websocket-proxy.py: Line 209: pidfile=self.pidfile, Line 210: ) Line 211: Line 212: def daemonStdHandles(self): Line 213: consoleLog = open(os.devnull, 'w+') > Alon, could you please give me a hint on daemon logging? when you use the python logger you should not relay on console log any more. all should go via the python logger. see the setupLogger, log is going to syslog, you also have the StreamHandler if not redirect log and you do not go into daemon. but I think you need >= 0.6 for the new python logging to be available. Line 214: return (consoleLog, consoleLog) Line 215: Line 216: def daemonContext(self): Line 217: # Line 259: target_host=None, Line 260: target_port=None, Line 261: wrap_mode='exit', Line 262: wrap_cmd=None, Line 263: RequestHandlerClass=OvirtProxyRequestHandler comma Line 264: ).start_server() Line 265: # WORKAROUND-BEGIN Line 266: # websockify exit because of signals. Line 267: # redirect it to expected termination sequence. -- To view, visit http://gerrit.ovirt.org/32138 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I13f94f91a1bdee0bfa93dc263de7e51395f7d7ce Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Frank Kobzik <fkob...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Frank Kobzik <fkob...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
