Frank Kobzik has posted comments on this change. Change subject: core: Adjust websockify to the new API ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/32138/1/packaging/services/ovirt-websocket-proxy/ovirt-websocket-proxy.py File packaging/services/ovirt-websocket-proxy/ovirt-websocket-proxy.py: Line 209: pidfile=self.pidfile, Line 210: ) Line 211: Line 212: def daemonStdHandles(self): Line 213: consoleLog = open(os.devnull, 'w+') Alon, could you please give me a hint on daemon logging? Even if I replace consoleLog with a handle to existing file, I don't see any output in that file (even though it's writable and I instruct the daemon to --redirect-output). Is there something more I have to do? Line 214: return (consoleLog, consoleLog) Line 215: Line 216: def daemonContext(self): Line 217: # -- To view, visit http://gerrit.ovirt.org/32138 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I13f94f91a1bdee0bfa93dc263de7e51395f7d7ce Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Frank Kobzik <fkob...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Frank Kobzik <fkob...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
