Frank Kobzik has posted comments on this change. Change subject: core: Graphics Device CRUD ......................................................................
Patch Set 8: (1 comment) http://gerrit.ovirt.org/#/c/25409/8/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/GraphicsType.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/GraphicsType.java: Line 1: package org.ovirt.engine.core.common.businessentities; Line 2: Line 3: import org.ovirt.engine.core.common.utils.VmDeviceType; Line 4: Line 5: public enum GraphicsType { > ok, i dont mind doning that as 'next step' but i really want to to clean ol (forgot to post this comment, adding it now) - I'll try to analyze the complexity of removing the attribute from VmStatic and keep you updated. - RunOnce: You mean we'd have some kind of temporary devices in vm_dynamic? Or in vm_device? Line 6: Line 7: SPICE(VmDeviceType.SPICE), Line 8: VNC(VmDeviceType.VNC); Line 9: -- To view, visit http://gerrit.ovirt.org/25409 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If9eed1ddb4aa8e8376ba5eff662f1bdf49fda800 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Frank Kobzik <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Frank Kobzik <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
